Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-control-regex has unnecessary code #6438

Closed
ljharb opened this issue Jun 16, 2016 · 5 comments
Closed

no-control-regex has unnecessary code #6438

ljharb opened this issue Jun 16, 2016 · 5 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing rule Relates to ESLint's core rules

Comments

@ljharb
Copy link
Sponsor Contributor

ljharb commented Jun 16, 2016

While investigating a fix for #6293, I discovered that the test in 141b778 continues to pass even without some of the rule code.

I'm filing this per #6437 (comment) so there's an issue matching the PR.
@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Jun 16, 2016
ljharb added a commit to ljharb/eslint that referenced this issue Jun 16, 2016
@ljharb
Chore: no-control-regex: Remove seemingly unnecessary logic.
c6345bd 
The test in eslint@141b778 continues to pass even without this code.

Fixes eslint#6438.
ljharb added a commit to ljharb/eslint that referenced this issue Jun 16, 2016
@ljharb
Chore: no-control-regex: Remove unnecessary logic (fixes eslint#6438)
a18e41b 
The test in eslint@141b778 continues to pass even without this code.
@platinumazure platinumazure added rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Jun 16, 2016
@nzakas nzakas mentioned this issue Jun 17, 2016
Closed
@ljharb
Copy link
Sponsor Contributor Author

ljharb commented Jun 20, 2016

Tagging @efegurkan just in case :-)

@ljharb
Copy link
Sponsor Contributor Author

ljharb commented Jun 24, 2016

@efegurkan ping - any update on this one?

@efegurkan
Copy link
Contributor

@ljharb I didn't had enough time to work on it yet. But I'm guessing there is something wrong with test execution. I'll add details on here when I have time.

@efegurkan efegurkan mentioned this issue Jul 24, 2016
Merged
@efegurkan
Copy link
Contributor

efegurkan commented Jul 24, 2016 •
edited

@ljharb I just sent a pull request to fix this. Sorry for blocking so long 😞 .

The problem was the tests as we guessed before. I was not checking literal's on tests instead I was checking literals on a string. Basically /\x01/.toString() is not equal to "/\x01".toString() .

As soon as #6752 gets approved you will be safe to work on the fix for #6293. Sorry for delaying again.

@ilyavolodin ilyavolodin added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jul 24, 2016
@ljharb
Copy link
Sponsor Contributor Author

ljharb commented Aug 4, 2016

Linking to #6839

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ljharb @platinumazure @ilyavolodin @efegurkan @eslintbot