Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: new "clang" report formatter #6064

Closed
aparajita opened this issue May 4, 2016 · 6 comments
Closed

Proposal: new "clang" report formatter #6064

aparajita opened this issue May 4, 2016 · 6 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion feature This change adds a new feature to ESLint

Comments

@aparajita
Copy link
Contributor

I'd like to propose that you include my clang-style formatter with the eslint distro. I'll be happy to maintain it.

https://github.com/cappuccino/eslint-clang-formatter

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label May 4, 2016
@ilyavolodin ilyavolodin added core Relates to ESLint's core APIs and features feature This change adds a new feature to ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels May 4, 2016
@ilyavolodin
Copy link
Member

I think this is a cross between our standard stylish formatter and JSCS formatter that will be ported to ESLint.

@aparajita
Copy link
Contributor Author

Yes, sort of, but that was why I created it. The stylish formatter provides no context info and the JSCS formatter is way too verbose. Also, my formatter allows the colors to be customized.

@nzakas
Copy link
Member

nzakas commented May 4, 2016

Hmm, I'm not sure there's a lot of value in including this in the core if you already have it as a separate package. I think it would be best if you maintain this as a separate package. Once we do #5900, it will be even easier for people to use.

@aparajita
Copy link
Contributor Author

Once #5900 is done, then it would make sense to keep it separate. But the main reason I asked to include it in the main distro is discoverability. Currently you mention that third party formatters are possible, but don't provide any links or even suggestions how to find them. I propose to have a curated list of third party formatters here.

@nzakas
Copy link
Member

nzakas commented May 5, 2016

Discoverability is a problem for configs and plugins as well. We don't have a good solution for that yet. I don't think just adding a list to the formatters page makes much sense, so I'd rather hold off until we have a chance to look at discoverability across the board.

@aparajita
Copy link
Contributor Author

Fair enough, then I'll close this.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion feature This change adds a new feature to ESLint
Projects
None yet
Development

No branches or pull requests

4 participants