Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-fixing to newline-after-var #5959

Closed
kaicataldo opened this issue Apr 25, 2016 · 8 comments
Closed

Add auto-fixing to newline-after-var #5959

kaicataldo opened this issue Apr 25, 2016 · 8 comments
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@kaicataldo
Copy link
Member

kaicataldo commented Apr 25, 2016

Similar to #5958.

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Apr 25, 2016
@kaicataldo kaicataldo added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Apr 25, 2016
@alberto alberto added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Apr 25, 2016
@vitorbal
Copy link
Member

@kaicataldo maybe I could give this one a shot? If you're not already on it :)

@kaicataldo
Copy link
Member Author

@vitorbal I think @markelog was going to take a look at this - if not, it's all yours!

@markelog
Copy link
Member

Mine! :)

Hope that's okay

@markelog markelog self-assigned this Apr 25, 2016
@vitorbal
Copy link
Member

Of course! All yours :)
On Tue, Apr 26, 2016 at 1:11 AM Oleg Gaidarenko notifications@github.com
wrote:

Mine! :)

Hope that's okay


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#5959 (comment)

@cristian-sima
Copy link

Any update on this auto-fix?

It is so frustrating to add them manually :)

I think as long as you detect them, there should not be very difficult to add a \n at the end of the var block

@markelog
Copy link
Member

It is on my list, I even started it at one point, but there is a lot of to be done here, so i'm a will kick this up again in few weeks hopefully

@platinumazure
Copy link
Member

@markelog Is it worth unassigning yourself in case someone else wants to jump in on this? (Or, better, is there anything other team members can take off your plate?)

@markelog
Copy link
Member

Am still planning do it, but if someone ready to start working on it right now, then yeah, re-assign away :)

@not-an-aardvark not-an-aardvark self-assigned this Oct 17, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

No branches or pull requests

8 participants