callback-return does not work with object methods

[fakewaffle]

I've read the documentation for the rule, but did not see anything related to this; nor could I find an issue.

.eslintrc

{
    "env" : {
        "node" : true
    },

    "rules" : {
        "callback-return" : [ 2, [ "callback", "cb", "done", "next", "send.error", "send.success", "send.fail", "reply" ] ]
    }
}

callback-return.js

'use strict'

( function ( item, send, callback ) {
    if ( item ) {
        send.fail();
    }

    send.success();

    if ( item ) {
        callback( item );
    }

    callback();
} );

console

~/Source/temp
> eslint -c .eslintrc callback-return.js

~/Source/temp/callback-return.js
  11:3  error  Expected return with your callback function  callback-return

✖ 1 problem (1 error, 0 warnings)

Given the options I supplied to the rule, I would expect ESLint to give an error for send.fail();.

Thoughts?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[gyandeeps]

Based on the code it only works for callee as Identifier and not for callee as MemberExpression.
Reference: https://github.com/eslint/eslint/blob/master/lib/rules/callback-return.js#L41-L43

@fakewaffle what is the eslint version you are using?
@eslint/eslint-team Thoughts?

[nzakas]

I'm open to this enhancement.

@fakewaffle do you want to submit a pull request?

[fakewaffle]

@gyandeeps v1.10.3.

@nzakas Yes!

[gyandeeps]

@fakewaffle I can see u have done implementation but you havent opened a pull request. I dont know if you forgot to that or is deliberate. Just a reminder. 😄

[fakewaffle]

@gyandeeps #4716?

[ghost]

If no one is currently working on this, I'd love to give it a shot and pickup where @fakewaffle left off.

[ilyavolodin]

@josectello Go for it!