From 7c8de9210aed6616eb5fb819ceb9bf4cb66735bf Mon Sep 17 00:00:00 2001 From: Kevin Partington Date: Thu, 6 Jul 2017 19:59:55 -0500 Subject: [PATCH] Docs: Clarified PR guidelines in maintainer guide (#8876) --- docs/maintainer-guide/pullrequests.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/maintainer-guide/pullrequests.md b/docs/maintainer-guide/pullrequests.md index fffeb75b5fd..3b5618389d8 100644 --- a/docs/maintainer-guide/pullrequests.md +++ b/docs/maintainer-guide/pullrequests.md @@ -11,14 +11,14 @@ Anyone, both team members and the public, may leave comments on pull requests. When a pull request is opened, the bot will check the following: 1. Has the submitter signed a CLA? -1. Is the commit message summary in the correct format? Double-check that the tag ("Fix:", "New:", etc.) is correct based on the issue. Documentation-only pull requests do not require an issue. -1. Does the commit summary reference an issue? +1. Is the commit message summary in the correct format? 1. Is the commit summary too long? The bot will add a comment specifying the problems that it finds. You do not need to look at the pull request any further until those problems have been addressed (there's no need to comment on the pull request to ask the submitter to do what the bot asked - that's why we have the bot!). Once the bot checks have been satisfied, you check the following: +1. Double-check that the commit message tag ("Fix:", "New:", etc.) is correct based on the issue (or, if no issue is referenced, based on the stated problem). 1. Does the code follow our conventions (including header comments, JSDoc comments, etc.)? If not, please leave that feedback and reference the conventions document. 1. For code changes: * Are there tests that verify the change? If not, please ask for them. @@ -38,6 +38,7 @@ Committers may merge a pull request if it is a non-breaking change and is: 1. A bug fix (for either rules or core) 1. A dependency upgrade 1. Related to the build system +1. A chore In addition, committers may merge any non-breaking pull request if it has been approved by at least one TSC member.