From 3fc4e3f7a5e0d04950490ed8af08dfba0b270ecc Mon Sep 17 00:00:00 2001 From: Teddy Katz Date: Mon, 9 Jan 2017 17:08:14 -0500 Subject: [PATCH] Fix: prefer-destructuring reporting compound assignments (fixes #7881) (#7882) --- lib/rules/prefer-destructuring.js | 4 +++- tests/lib/rules/prefer-destructuring.js | 6 +++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/rules/prefer-destructuring.js b/lib/rules/prefer-destructuring.js index c3fbcaa6310..38e8e2903aa 100644 --- a/lib/rules/prefer-destructuring.js +++ b/lib/rules/prefer-destructuring.js @@ -158,7 +158,9 @@ module.exports = { * @returns {void} */ function checkAssigmentExpression(node) { - performCheck(node.left, node.right, node); + if (node.operator === "=") { + performCheck(node.left, node.right, node); + } } //-------------------------------------------------------------------------- diff --git a/tests/lib/rules/prefer-destructuring.js b/tests/lib/rules/prefer-destructuring.js index fb92e75dae3..ae0633408fa 100644 --- a/tests/lib/rules/prefer-destructuring.js +++ b/tests/lib/rules/prefer-destructuring.js @@ -72,9 +72,9 @@ ruleTester.run("prefer-destructuring", rule, { { code: "({ foo } = object);" }, - { - code: "[foo] = array;" - } + "[foo] = array;", + "foo += array[0]", + "foo += bar.foo" ], invalid: [