From 2272cbf2c1e3ad24d8dae517f1f5dafcc9040c13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=96=9B=E5=AE=9A=E8=B0=94=E7=9A=84=E7=8C=AB?= Date: Tue, 9 May 2017 04:47:41 +0800 Subject: [PATCH] 1.update category. 2.update comments. --- lib/rules/getter-return.js | 2 +- tests/lib/rules/getter-return.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/rules/getter-return.js b/lib/rules/getter-return.js index ba081853f631..84fd2ae67f96 100644 --- a/lib/rules/getter-return.js +++ b/lib/rules/getter-return.js @@ -47,7 +47,7 @@ module.exports = { meta: { docs: { description: "enforce `return` statements in getters", - category: "Best Practices", + category: "Possible Errors", recommended: false }, fixable: null, diff --git a/tests/lib/rules/getter-return.js b/tests/lib/rules/getter-return.js index fab0a9a2030d..d2a9d4d3edaa 100644 --- a/tests/lib/rules/getter-return.js +++ b/tests/lib/rules/getter-return.js @@ -18,14 +18,14 @@ const RuleTester = require("../../../lib/testers/rule-tester"); const ruleTester = new RuleTester(); -// TODO: data is not working, so specify a name: "getter 'bar'" +// data is not working, so specify a name: "getter 'bar'" const name = "getter 'bar'"; const noReturnMessage = `Expected to return a value in ${name}.`; const noLastReturnMessage = `Expected to return a value at the end of ${name}.`; const parserOptions = { ecmaVersion: 6 }; const options = [{ noImplicit: true }]; -ruleTester.run("enforce-return-in-getter", rule, { +ruleTester.run("getter-return", rule, { valid: [