-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
/
prefer-destructuring.js
140 lines (131 loc) · 4.05 KB
/
prefer-destructuring.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
/**
* @fileoverview Prefer destructuring from arrays and objects
* @author Alex LaFroscia
*/
"use strict";
//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------
const rule = require("../../../lib/rules/prefer-destructuring"),
RuleTester = require("../../../lib/testers/rule-tester");
//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------
const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6 } });
ruleTester.run("prefer-destructuring", rule, {
valid: [
{
code: "var [foo] = array;"
},
{
code: "var { foo } = object;"
},
{
// Ensure that this doesn't break variable declarating without assignment
code: "var foo;"
},
{
// Ensure that the default behavior does not require desturcturing when renaming
code: "var foo = object.bar;",
options: [{ object: true }]
},
{
code: "var foo = object.bar;",
options: [{ object: true }, { enforceForRenamedProperties: false }]
},
{
code: "var foo = object['bar'];",
options: [{ object: true }, { enforceForRenamedProperties: false }]
},
{
code: "var foo = object[bar];",
options: [{ object: true }, { enforceForRenamedProperties: false }]
},
{
code: "var { bar: foo } = object;",
options: [{ object: true }, { enforceForRenamedProperties: true }]
},
{
code: "var { [bar]: foo } = object;",
options: [{ object: true }, { enforceForRenamedProperties: true }]
},
{
code: "var foo = array[0];",
options: [{ array: false }]
},
{
code: "var foo = object.foo;",
options: [{ object: false }]
},
{
code: "var foo = object['foo'];",
options: [{ object: false }]
},
{
code: "({ foo } = object);"
},
"[foo] = array;",
"foo += array[0]",
"foo += bar.foo"
],
invalid: [
{
code: "var foo = array[0];",
errors: [{
message: "Use array destructuring",
type: "VariableDeclarator"
}]
},
{
code: "foo = array[0];",
errors: [{
message: "Use array destructuring",
type: "AssignmentExpression"
}]
},
{
code: "var foo = object.foo;",
errors: [{
message: "Use object destructuring",
type: "VariableDeclarator"
}]
},
{
code: "var foobar = object.bar;",
options: [{ object: true }, { enforceForRenamedProperties: true }],
errors: [{
message: "Use object destructuring",
type: "VariableDeclarator"
}]
},
{
code: "var foo = object[bar];",
options: [{ object: true }, { enforceForRenamedProperties: true }],
errors: [{
message: "Use object destructuring",
type: "VariableDeclarator"
}]
},
{
code: "var foo = array['foo'];",
errors: [{
message: "Use object destructuring",
type: "VariableDeclarator"
}]
},
{
code: "foo = array.foo;",
errors: [{
message: "Use object destructuring",
type: "AssignmentExpression"
}]
},
{
code: "foo = array['foo'];",
errors: [{
message: "Use object destructuring",
type: "AssignmentExpression"
}]
}
]
});