Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapterOptions not usable for query and queryRecord #4497

Closed
JackCA opened this issue Aug 12, 2016 · 0 comments · Fixed by #4856
Closed

adapterOptions not usable for query and queryRecord #4497

JackCA opened this issue Aug 12, 2016 · 0 comments · Fixed by #4856

Comments

@JackCA
Copy link

JackCA commented Aug 12, 2016

adapterOptions is a great way to communicate one-off settings to an adapter; however, it does not appear that it is usable for query or queryRecord.

Here is a demonstration on how passing adapterOptions into the query argument for store.query and store.queryRecord will just result in the options being parameterized (which according to the docs is exactly what should be happening -- it mentions directly passing on anything present there).

I would assume there are a few paths forward:

  • allow adapterOptions to be passed into the query argument for store.query and store.queryRecord, automatically strip that key and provide it to the snapshot, and then update the docs to document that special behavior
  • allow a third options argument to store.query and store.queryRecord
  • ????
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant