Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon support #395

Closed
6 tasks done
joostdevries opened this issue Apr 12, 2016 · 11 comments
Closed
6 tasks done

Addon support #395

joostdevries opened this issue Apr 12, 2016 · 11 comments
Assignees

Comments

@joostdevries
Copy link
Member

joostdevries commented Apr 12, 2016

  • Stabilize addon API
  • Nice addon loading indicator
  • Auto reload/refresh after addon build completes
  • Handle addon build errors
  • Handle addon config in twiddle.json
  • Handle multiple ember / ember-template-compiler versions
@joostdevries joostdevries self-assigned this Apr 12, 2016
@tamebadger
Copy link

Any thought regarding docs or usage instructions so far ? Wondering how to use addons now myself :D

@Gaurav0
Copy link
Contributor

Gaurav0 commented May 5, 2016

Once addons are supported properly, we will add a section in twiddle.json.

@joostdevries
Copy link
Member Author

@Gaurav0 @alexspeller an update on addons:

The current addon system builds addons in Docker containers on top of Amazon ECS. Basically I've created an API endpoint which - when hit - tries to run the build on ECS. The downside of this is/was that ECS does not handle scheduling so when there are no resources available (it can run max. 2 build in parallel), the build fails.

I've created a custom scheduler which schedules builds on SQS as intermediate step and am currently in the process of placing that in the middle of the system. I expect this to be done this week. The end result should be a very robust and quite secure online addon building system. It has some nice features such as:

  • Each build gets temporary S3 credentials limited to it's own 'subdirectory', so a rogue addon install script could never compromise other addons stored in our S3 storage.
  • Builds typically run within 30s.
  • Builds are queued in SQS and after each successful build we check the queue to make sure builds move as fast as possible.

@joostdevries
Copy link
Member Author

@Gaurav0 I've began moving everything to the new architecture.

Base URL's for API:

@joostdevries
Copy link
Member Author

I expect to finish the migration tonight/tomorrow (Dutch time).

@joostdevries
Copy link
Member Author

joostdevries commented Jun 23, 2016

Discovered a new issue: Alpine Linux support is not present for node-sass, sass/node-sass#1589. But they're working on it.

@joostdevries
Copy link
Member Author

We now fully support addons for 2.6 and 1.13 in Ember Twiddle canary (https://canary.ember-twiddle.com). Docs on adding more versions at https://github.com/joostdevries/twiddle-backend

@acorncom
Copy link
Member

👍

@alexspeller
Copy link
Member

This is awesome!

@ritesh83
Copy link

@joostdevries I created a twiddle with ember-cli-jstree addon but its throwing a security error.
Could you take a look? Maybe I'm doing something wrong
https://ember-twiddle.com/82809a6f7b4570b4de8416260fbb59db

@joostdevries
Copy link
Member Author

@ritesh83 This is unrelated to addon support. The script tries to load a WebWorker which afaik is not enabled in sandbox mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants