Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating project to ember-cli@2.12.1 seems to fail on untranspiled ember-mocha in vendor.js #189

Closed
ghost opened this issue Apr 17, 2017 · 5 comments

Comments

@ghost
Copy link

ghost commented Apr 17, 2017

This is a private repo, so i can't post the config. Mocha specific dependencies:

  • ember-cli-mocha@0.13.1
  • ember-mocha@0.8.11 (also tried bumping to ember-mocha@0.11.0
  • ember-cli@2.11.1

When I try to update to ember-cli@2.12.1, running ember test --server is broken. Navigating to localhost:7357 serves up app/index.html.
Devtools Console output:
screen shot 2017-04-17 at 5 29 27 pm
Relevant capture of test-support.js:
screen shot 2017-04-17 at 5 32 34 pm
I've tried bumping versions but am getting nowhere. Is there a specific incompatibility between ember-mocha, ember-cli-mocha, and ember-cli? I can try putting the dependencies into a fake repo if helpful.

@Turbo87
Copy link
Member

Turbo87 commented Apr 18, 2017

what version of ember-test-helpers do you have?

/cc @rwjblue

@ghost
Copy link
Author

ghost commented Apr 18, 2017

@Turbo87 0.6.3

$ npm ls ember-test-helpers 
└─┬ ember-cli-mocha@0.13.1
  └─┬ ember-mocha@0.11.0
    └── ember-test-helpers@0.6.3 

@Dhaulagiri
Copy link
Contributor

We had the same problem. I think you have to also upgrade ember-cli-mocha to 0.13.2 for it to work with ember-cli 2.12.

@Turbo87
Copy link
Member

Turbo87 commented Apr 18, 2017

@Dhaulagiri right, thanks for figuring that out. I somehow thought 0.13.1 was the latest release, but you are right that 0.13.2 (including #166) should fix this issue.

@Turbo87 Turbo87 closed this as completed Apr 18, 2017
@ghost
Copy link
Author

ghost commented Apr 19, 2017

thanks, that resolved it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants