Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no longer support bool param for setHighlightMode #11981

Merged
merged 1 commit into from Feb 20, 2018
Merged

no longer support bool param for setHighlightMode #11981

merged 1 commit into from Feb 20, 2018

Conversation

codebytere
Copy link
Member

What it says on the tin, per 2.0 Breaking Changes

// Deprecated
tray.setHighlightMode(true)
// Replace with
tray.setHighlightMode('on')
  
// Deprecated
tray.setHighlightMode(false)
// Replace with
tray.setHighlightMode('off')

@codebytere codebytere requested a review from a team February 20, 2018 15:08
@jkleinsc jkleinsc merged commit dcaff20 into master Feb 20, 2018
@jkleinsc jkleinsc deleted the set-tray-highlightmode branch February 20, 2018 17:57
This was referenced Feb 20, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @ckerr @jkleinsc