release 4.0.0 (#812) #857
Merged
release 4.0.0 (#812) #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* start implementation * more code reuse * create useCombobox * start implementation for handlers * remove not needed call * input handlers * progress on handlers * fix close on toggle button click * remove unneeded state change types * add example to docsite * focus input at toggle click + reactNative * add setInputValue * rename root to combobox + tests * add icon to button * add item tests * add more menu tests * finished input tests + initial state * finish testing * don't apply handlers if disabled * add tests for disabled cases * apply mozilla button close fix * initial default values small refactor * improvements for docs * updates to the docs and readme * readme updates * prop types validation not on production * readme correction * add ts typings
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
======================================
Coverage 100% 100%
======================================
Files 8 12 +4
Lines 702 886 +184
Branches 158 184 +26
======================================
+ Hits 702 886 +184
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Will re-release this to 4.0.0. |
silviuaavram
added a commit
that referenced
this pull request
Dec 18, 2019
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release
useComboboxhook, adapts the TS typings and improves the docsite.The
useComboboxshould be the way forward when it comes to building an autocomplete component.Structure the docsite as a Hooks menu with a submenu for each hook. Each hook should be represented on a full page.
Details in #812.
BREAKING CHANGE: Remove
DownshiftInterfaceas it's not required anymore to makeDownshiftprops generic.You can pass your generic to the Downshift props as<Downshift<MyItem> {...props} />. #748BREAKING CHANGE: Change TS typings for
useSelect, in getter props, to specify that most of them will requirerefKeyin case the user renders a custom React component with a ref prop that has a different name thanref(likeinnerReffor instance). #812Each new
UseSelecttype is like: