Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check child is meaningless #890

Merged
merged 3 commits into from May 3, 2018
Merged

check child is meaningless #890

merged 3 commits into from May 3, 2018

Conversation

MrErHu
Copy link
Contributor

@MrErHu MrErHu commented Sep 21, 2017

Check child is meaning. when code run here, child must be null!

@coveralls
Copy link

coveralls commented Sep 21, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling bd2490d on MrErHu:master into 9affea6 on developit:master.

@pl12133 pl12133 mentioned this pull request Oct 14, 2017
Closed
@developit
Copy link
Member

I don't think this is true for children with mixed keyed/unkeyed.

@marvinhagemeister
Copy link
Member

@developit We reassign child to null just a few lines above this check https://github.com/developit/preact/blob/master/src/vdom/diff.js#L195 . Seems like this can be indeed removed.

marvinhagemeister
marvinhagemeister approved these changes May 3, 2018
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for spotting this 🎉

@marvinhagemeister marvinhagemeister merged commit 569bf97 into preactjs:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrErHu @coveralls @developit @marvinhagemeister