Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly add logo to README #1243

Merged
merged 1 commit into from Oct 22, 2018
Merged

Directly add logo to README #1243

merged 1 commit into from Oct 22, 2018

Conversation

reviewher
Copy link
Contributor

removing dependency on the soon-to-be-sunsetted rawgit service

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8b0bcc9 on reviewher:master into 382a640 on developit:master.

Copy link
Member

@andrewiggins andrewiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit 420a45c into preactjs:master Oct 22, 2018
@developit
Copy link
Member

I might move this to imgur or something to keep the repo root clean, or hotlink it from preactjs.com

@reviewher
Copy link
Contributor Author

It can be moved to a subdirectory. In any case, most projects include the logo in the project directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants