Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Flow's
Object
types is actually a violation of theunclear-type
linting rule:So, using it to type the exported
options
object may cause issues for developers that have Flow linting enabled. Also, specifically typing this will result in a better developer experience anyway :)As I started typing it, I ended up having to use
Function
andany
elsewhere. Ideally those types should be refined too, but since I'm not familiar with Preact's internals I decided to leave it as-is and maybe a reviewer can suggest the right direction?