Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the referential equality of the args to componentDidUpdate #1198

Merged
merged 1 commit into from Aug 25, 2018

Conversation

andrewiggins
Copy link
Member

Validate the referential equality of the args to componentDidUpdate. Make sure if props or state change, the objects aren't referentially equal. If they don't change, they should be the same reference.

@coveralls
Copy link

coveralls commented Aug 24, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 3e00b73 on andrewiggins:cdu-arg-tests into 7c3e6fe on developit:master.

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎉

@marvinhagemeister marvinhagemeister merged commit 2e53084 into preactjs:master Aug 25, 2018
@andrewiggins andrewiggins deleted the cdu-arg-tests branch August 25, 2018 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants