Fix preact/debug accessing attributes that don't have toString (#754)

* Fix accessing attributes that don't inherit Object * Use object's toString if it exists * Fix spacing * Fix spacing * Fix spacing
preactjs · Aug 20, 2017 · 68fa510 · 68fa510
1 parent 0a88752
commit 68fa510
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/debug/index.js b/debug/index.js
@@ -70,7 +70,17 @@ if (process.env.NODE_ENV === 'development') {
 
 		if (attributes) {
 			props = Object.keys(attributes).map(attr => {
-				return `${attr}=${JSON.stringify(attributes[attr] + '')}`;
+				const attrValue = attributes[attr];
+				let attrValueString;
+
+				// If it is an object but doesn't have toString(), use Object.toString
+				if (Object(attrValue) === attrValue && !attrValue.toString) {
+				  attrValueString = Object.prototype.toString.call(attrValue);
+				} else {
+				  attrValueString = attrValue + '';
+				}
+
+				return `${attr}=${JSON.stringify(attrValueString)}`;
 			});
 		}
 
@@ -82,4 +92,4 @@ if (process.env.NODE_ENV === 'development') {
 	};
 
 	require('preact/devtools');
-}
+}