fix(commons): avoid unicode regex encoding in axe.min.js #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeyyy
changed the title
RegExp objectRegExp object
WilcoFiers
approved these changes
Feb 10, 2020
WilcoFiers
changed the title
RegExp object
straker
pushed a commit
that referenced
this pull request
Feb 10, 2020
* fix: return unicode as literal instead of a regexp object * run fmt * reformat comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related issue - #2023 for description.
In this fix, we create a
RegExpliteral instead of creating a RegExp from a string, which changes uglify behaviour.This issue is not currently tested by any of the test coverage we have, because all of them use
axe.jsover a the minifiedaxe.min.js. This issue was identified under windows ecosystem when executing axe from attest-java using the minified source.Closes issue:
grunt-contrib-uglifydoes not treat unicode characters correctly #2023Reviewer checks
Required fields, to be filled out by PR reviewer(s)