Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(no-autoplay-audio): remove Number.isNaN check for node duration #2010

Merged
merged 1 commit into from Feb 3, 2020
Merged

fix(no-autoplay-audio): remove Number.isNaN check for node duration #2010

merged 1 commit into from Feb 3, 2020

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Feb 3, 2020 •
edited by WilcoFiers

Identified that Number.isNaN fails in IE11. Also it is a redundant check as we already check if !node.duration.

Closes issue:

  • NA

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@jeeyyy jeeyyy requested a review from a team as a code owner February 3, 2020 20:04
@WilcoFiers WilcoFiers merged commit 5359b3f into develop Feb 3, 2020
@WilcoFiers WilcoFiers deleted the remove-nan-check branch February 3, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeeyyy @WilcoFiers