Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria-valid-attr-value): mark as needs review for aria-current with invalid value #1998

Merged
merged 2 commits into from Jan 27, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jan 24, 2020

Aria-current with an invalid value is just treated as "aria-current=true."

With another value needing to be marked as incomplete we needed to have different remediation messages for each one (aria-describedby for missing id and aria-current for invalid value). Because of this we couldn't return an array of values since we needed to set the messageKey property of the data.

What this all means is that only one needs review item can be marked on an element at a time due to the need of different need review messages.

Closes issue: #1773

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner January 24, 2020 17:38
@straker straker merged commit 39b8eae into develop Jan 27, 2020
@straker straker deleted the ariaCurrent branch January 27, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants