Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(meta-viewport): mark as a best-practice rule instead of wcag failure #1960

Merged
merged 1 commit into from Jan 6, 2020
Merged

fix(meta-viewport): mark as a best-practice rule instead of wcag failure #1960

merged 1 commit into from Jan 6, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Dec 23, 2019 •
edited by jeeyyy

Since some mobile browsers ignore the <meta name="viewport"> settings while others have settings to ignore the tag, moving from a wcag failure to a best-practice failure.

Closes issue: #694

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner December 23, 2019 21:11
@straker straker merged commit 766f962 into develop Jan 6, 2020
@straker straker deleted the metaVieport branch January 6, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@jeeyyy jeeyyy jeeyyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@straker @WilcoFiers @jeeyyy