Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(isFocusable): return true for summary element and false for details element with summary child #1957

Merged
merged 2 commits into from Jan 22, 2020
Merged

fix(isFocusable): return true for summary element and false for details element with summary child #1957

merged 2 commits into from Jan 22, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Dec 19, 2019 •
edited by WilcoFiers

Closes issue: #1945

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner December 19, 2019 21:48
WilcoFiers
WilcoFiers previously requested changes Dec 20, 2019
View reviewed changes
lib/commons/dom/is-focusable.js Show resolved Hide resolved
test/commons/dom/is-focusable.js Show resolved Hide resolved
@straker straker merged commit 34ec2d7 into develop Jan 22, 2020
@straker straker deleted the detailsSummary branch January 22, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@straker @WilcoFiers