Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rule): no-autoplay-audio #1946

Merged
merged 24 commits into from Jan 20, 2020
Merged

feat(rule): no-autoplay-audio #1946

merged 24 commits into from Jan 20, 2020

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Dec 18, 2019 •
edited by straker

This rule checks that automatically playing audio/video does not last for more than 3 seconds, or the audio/video has a control mechanism to stop or mute it.

Closes issue:

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@jeeyyy jeeyyy mentioned this pull request Dec 20, 2019
Merged
2 tasks
@jeeyyy jeeyyy changed the title feat(rule): no-autoplay-audio [WIP] feat(rule): no-autoplay-audio Dec 26, 2019
@jeeyyy jeeyyy marked this pull request as ready for review January 10, 2020 17:12
@jeeyyy jeeyyy requested a review from a team as a code owner January 10, 2020 17:12
@jeeyyy jeeyyy changed the title [WIP] feat(rule): no-autoplay-audio feat(rule): no-autoplay-audio Jan 10, 2020
@jeeyyy jeeyyy added rules Issue or false result from an axe-core rule wai-tools labels Jan 10, 2020
straker
straker previously requested changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the changes to isHidden have to do with the rule. Can you explain please? (there are no test cases where a video/audio element is hidden)

lib/rules/no-autoplay-audio.json Outdated Show resolved Hide resolved
lib/rules/no-autoplay-audio.json Outdated Show resolved Hide resolved
lib/rules/no-autoplay-audio.json Outdated Show resolved Hide resolved
lib/core/utils/preload-media.js Outdated Show resolved Hide resolved
lib/core/utils/is-hidden.js Outdated Show resolved Hide resolved
lib/checks/media/no-autoplay-audio.json Outdated Show resolved Hide resolved
test/checks/media/no-autoplay-audio.js Outdated Show resolved Hide resolved
test/integration/rules/no-autoplay-audio/no-autoplay-audio.html Outdated Show resolved Hide resolved
test/rule-matches/no-autoplay-audio-matches.js Outdated Show resolved Hide resolved
test/rule-matches/no-autoplay-audio-matches.js Show resolved Hide resolved
@jeeyyy jeeyyy requested a review from straker January 15, 2020 14:14
straker
straker previously requested changes Jan 15, 2020
View reviewed changes
lib/core/utils/is-hidden.js Outdated Show resolved Hide resolved
test/core/utils/is-hidden.js Outdated Show resolved Hide resolved
test/core/utils/is-hidden.js Outdated Show resolved Hide resolved
test/integration/rules/no-autoplay-audio/no-autoplay-audio.html Outdated Show resolved Hide resolved
@jeeyyy jeeyyy requested a review from straker January 15, 2020 18:25
straker
straker previously approved these changes Jan 16, 2020
View reviewed changes
@jeeyyy jeeyyy requested a review from straker January 20, 2020 14:58
@jeeyyy jeeyyy merged commit b2373cb into develop Jan 20, 2020
@jeeyyy jeeyyy deleted the rule-no-autoplay-audio branch January 20, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
rules Issue or false result from an axe-core rule wai-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeeyyy @straker