fix: compute orientation lock from various transformation functions #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Dec 13, 2019
WilcoFiers
previously requested changes
Dec 16, 2019
WilcoFiers
previously approved these changes
Dec 17, 2019
|
@WilcoFiers - I had to merge from develop to get one of the status checks to run, so will need your approval again |
WilcoFiers
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles computing of orientation lock when transform is applied using any of the below transformation properties, that could affect rotation along the z-axis
Closes issue:
Reviewer checks
Required fields, to be filled out by PR reviewer(s)