New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(link-name): test role=link when there is no href #1921

Merged

WilcoFiers merged 1 commit into develop from link-name-fix

Dec 4, 2019

Contributor

WilcoFiers commented Nov 28, 2019 •

edited by jeeyyy

The link-name rule shouldn't be limited to things with an href attribute.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

Follows the commit message policy, appropriate for next version
Code is reviewed for security


          fix(link-name): test role=link when there is no href

27674de

WilcoFiers requested a review from a team as a code owner

November 28, 2019 14:16

jeeyyy approved these changes

View reviewed changes

straker approved these changes

View reviewed changes

WilcoFiers merged commit 6db28bc into develop

WilcoFiers deleted the link-name-fix branch

December 4, 2019 11:55

straker pushed a commit that referenced this pull request


          fix(link-name): test role=link when there is no href (#1921)

e839c57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment