Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify reporting of ul > li[role=button] and other list rules with roles #1919

Closed
WilcoFiers opened this issue Nov 27, 2019 · 2 comments
Closed
Assignees
Labels
feat New feature or enhancement rule metadata Issues in the rule metadata code (lib/rules)
Milestone

Comments

@WilcoFiers
Copy link
Contributor

Similar to #1894, axe-core reports the following code this way:

<ul>
  <li role="button">Stuff</li>
</ul>

Fix the following:
List element has direct children that are not allowed inside

  • elements

  • This message is a little misleading. We should make sure it's clear that this is failing because of the role. Axe-core should be clear that whenever something is failed for having it's implicit role changes, that the role attribute is the reason for the failure.

    @WilcoFiers WilcoFiers added feat New feature or enhancement rule metadata Issues in the rule metadata code (lib/rules) labels Nov 27, 2019
    @WilcoFiers WilcoFiers added this to the Axe-core 3.5 milestone Nov 27, 2019
    @straker straker self-assigned this Dec 19, 2019
    @straker
    Copy link
    Contributor

    straker commented Jan 7, 2020

    @jeankaplansky I don't believe the rule-help docs need to be updated since we just added a new remediation message to clarify the problem.

    @padmavemulapati
    Copy link

    Showing a message "List element has direct children that are not allowed inside

  • elements", which is the fix seeing.

    image

  • Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    feat New feature or enhancement rule metadata Issues in the rule metadata code (lib/rules)
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants