Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): add lang query parameter to helpUrl when builing with a locale #1909

Merged
merged 3 commits into from Nov 21, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Nov 19, 2019

Closes issue: #1861

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner November 19, 2019 22:30
@straker straker changed the title fix(build); add lang query parameter to helpUrl when builing with a locale fix(build): add lang query parameter to helpUrl when builing with a locale Nov 19, 2019
@straker straker merged commit 8c5f9ef into develop Nov 21, 2019
@straker straker deleted the buildHelpUrl branch November 21, 2019 16:29
straker added a commit that referenced this pull request Dec 11, 2019
…ocale (#1909)

* fix(build); add lang query parameter to helpUrl when builing with a locale

* add test

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants