feat(rule): identical-links-same-purpose #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS. you linked to the Filename is valid accessible name docs |
straker
previously requested changes
Jun 21, 2019
|
@straker upon discussing with @WilcoFiers decided to compare full resource ( |
jeeyyy
changed the title
jeeyyy
changed the title
WilcoFiers
previously requested changes
Jul 3, 2019
test/integration/full/identical-links-same-purpose/incomplete.html
Outdated
Show resolved
Hide resolved
jeeyyy
changed the title
jeeyyy
changed the title
WilcoFiers
previously requested changes
Jan 14, 2020
| parser.pathname | ||
| ); | ||
| return { | ||
| protocol: parser.protocol, |
There was a problem hiding this comment.
Even so, "http" and "https" should be treated as the same, same for ftp and ftps. Please add that.
WilcoFiers
previously requested changes
Jan 15, 2020
WilcoFiers
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new rule
identical-links-same-purposeFurther Reading:
Closes issue:
Reviewer checks
Required fields, to be filled out by PR reviewer(s)