From d22cb30ad29f5d1aec089eea3544ff88f3b4f8ab Mon Sep 17 00:00:00 2001 From: Steven Lambert Date: Thu, 7 Nov 2019 11:21:06 -0700 Subject: [PATCH] feat(layout-table): deprecate layout-table rule and checks (#1885) --- doc/rule-descriptions.md | 2 +- lib/checks/tables/has-caption.json | 1 + lib/checks/tables/has-summary.json | 1 + lib/checks/tables/has-th.json | 1 + lib/rules/layout-table.json | 3 ++- 5 files changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/rule-descriptions.md b/doc/rule-descriptions.md index b6a141ad78..281ef02c84 100644 --- a/doc/rule-descriptions.md +++ b/doc/rule-descriptions.md @@ -57,7 +57,7 @@ | landmark-no-duplicate-contentinfo | Ensures the document has at most one contentinfo landmark | Moderate | cat.semantics, best-practice | true | | landmark-one-main | Ensures the document has only one main landmark and each iframe in the page has at most one main landmark | Moderate | cat.semantics, best-practice | true | | landmark-unique | Landmarks must have a unique role or role/label/title (i.e. accessible name) combination | Moderate | cat.semantics, best-practice | true | -| layout-table | Ensures presentational <table> elements do not use <th>, <caption> elements or the summary attribute | Serious | cat.semantics, wcag2a, wcag131 | true | +| layout-table | Ensures presentational <table> elements do not use <th>, <caption> elements or the summary attribute | Serious | cat.semantics, wcag2a, wcag131, deprecated | false | | link-in-text-block | Links can be distinguished without relying on color | Serious | cat.color, experimental, wcag2a, wcag141 | true | | link-name | Ensures links have discernible text | Serious | cat.name-role-value, wcag2a, wcag412, wcag244, section508, section508.22.a | true | | list | Ensures that lists are structured correctly | Serious | cat.structure, wcag2a, wcag131 | true | diff --git a/lib/checks/tables/has-caption.json b/lib/checks/tables/has-caption.json index f44d3bbd8c..8bab37c55f 100644 --- a/lib/checks/tables/has-caption.json +++ b/lib/checks/tables/has-caption.json @@ -1,6 +1,7 @@ { "id": "has-caption", "evaluate": "has-caption.js", + "deprecated": true, "metadata": { "impact": "serious", "messages": { diff --git a/lib/checks/tables/has-summary.json b/lib/checks/tables/has-summary.json index 011c64fb9b..4e9a6f680c 100644 --- a/lib/checks/tables/has-summary.json +++ b/lib/checks/tables/has-summary.json @@ -1,6 +1,7 @@ { "id": "has-summary", "evaluate": "has-summary.js", + "deprecated": true, "metadata": { "impact": "serious", "messages": { diff --git a/lib/checks/tables/has-th.json b/lib/checks/tables/has-th.json index 884035bf93..61bfafdf05 100644 --- a/lib/checks/tables/has-th.json +++ b/lib/checks/tables/has-th.json @@ -1,6 +1,7 @@ { "id": "has-th", "evaluate": "has-th.js", + "deprecated": true, "metadata": { "impact": "serious", "messages": { diff --git a/lib/rules/layout-table.json b/lib/rules/layout-table.json index 960862bd94..faa2bba75d 100644 --- a/lib/rules/layout-table.json +++ b/lib/rules/layout-table.json @@ -2,11 +2,12 @@ "id": "layout-table", "selector": "table", "matches": "layout-table-matches.js", - "tags": ["cat.semantics", "wcag2a", "wcag131"], + "tags": ["cat.semantics", "wcag2a", "wcag131", "deprecated"], "metadata": { "description": "Ensures presentational elements do not use
,
elements or the summary attribute", "help": "Layout tables must not use data table elements" }, + "enabled": false, "all": [], "any": [], "none": ["has-th", "has-caption", "has-summary"]