From 4635fef8bafd1c1cf916962693d0deee082266cf Mon Sep 17 00:00:00 2001
From: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Date: Thu, 14 Nov 2019 12:00:56 +0100
Subject: [PATCH] fix: input[role=button][value='correct'] should pass (#1897)

---
 lib/rules/button-name.json                          | 4 ++--
 test/integration/rules/button-name/button-name.html | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/rules/button-name.json b/lib/rules/button-name.json
index 826a3da068..db3b0b40ec 100644
--- a/lib/rules/button-name.json
+++ b/lib/rules/button-name.json
@@ -1,6 +1,6 @@
 {
 	"id": "button-name",
-	"selector": "button, [role=\"button\"]",
+	"selector": "button, [role=\"button\"]:not(input)",
 	"tags": [
 		"cat.name-role-value",
 		"wcag2a",
@@ -22,4 +22,4 @@
 		"non-empty-title"
 	],
 	"none": []
-}
+}
\ No newline at end of file
diff --git a/test/integration/rules/button-name/button-name.html b/test/integration/rules/button-name/button-name.html
index b95941611f..bb43145644 100644
--- a/test/integration/rules/button-name/button-name.html
+++ b/test/integration/rules/button-name/button-name.html
@@ -11,3 +11,5 @@
 <button id="combo" aria-label="Aria Name">Name</button>
 <button id="buttonTitle" title="Title"></button>
 <button id="buttonvalue" value="foo" tabindex="-1"></button>
+
+<input type="submit" value="submit" role="button" id="ignored" />