Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with v22 of semantic-release #176

Closed
mirkolenz opened this issue Sep 20, 2023 · 4 comments
Closed

Incompatibility with v22 of semantic-release #176

mirkolenz opened this issue Sep 20, 2023 · 4 comments

Comments

@mirkolenz
Copy link

mirkolenz commented Sep 20, 2023

Describe the bug

When using v4 of this action with v22 of semantic-release, I get the following error:

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './package.json' is not defined by "exports" in /home/runner/work/_actions/cycjimmy/semantic-release-action/v4/node_modules/semantic-release/package.json

I found out that in v21, semantic-release used the attribute main in its package.json, but as of v22 has switched to the more modern exports attribute. It seems that the following snippet (maybe others as well?) is incompatible with this change:

const semanticVersion = require('semantic-release/package.json').version;

Example Workflow

https://github.com/recap-utr/arg-services/blob/main/.github/workflows/release.yml

Additional Context
There is an open issue in the repo of semantic-release about the change from main to exports: semantic-release/semantic-release#2968

@aperov9
Copy link

aperov9 commented Sep 20, 2023

+1 ran into the same error after setting semantic-release to v22 with the action on v4

@travi
Copy link

travi commented Sep 23, 2023

@mirkolenz
Copy link
Author

mirkolenz commented Sep 23, 2023

@travi Thank you, I just tested the new version in my CI pipeline and it works just as expected! Shall we leave the issue open to track the upcoming API changes (semantic-release/semantic-release#2978) or close it for now?

akikanellis added a commit to akikanellis/advent-of-code that referenced this issue Oct 14, 2023
conventional-changelog v7 is only compatible with semantic-release v22+.
Previously semantic-release v20+ was not compatible with
cycjimmy/semantic-release-action but this has now been fixed.

Therefore upgrading semantic-release to latest should fix the release
tagging.

See:

- cycjimmy/semantic-release-action#176
- semantic-release/semantic-release#2978
- semantic-release/semantic-release#2929
akikanellis added a commit to akikanellis/advent-of-code that referenced this issue Oct 14, 2023
conventional-changelog v7 is only compatible with semantic-release v22+.
Previously semantic-release v20+ was not compatible with
cycjimmy/semantic-release-action but this has now been fixed.

Therefore upgrading semantic-release to latest should fix the release
tagging.

See:

- cycjimmy/semantic-release-action#176
- semantic-release/semantic-release#2978
- semantic-release/semantic-release#2929
stefanfreitag added a commit to stefanfreitag/terraform-aws-msk-status-monitor that referenced this issue Nov 12, 2023
@cycjimmy
Copy link
Owner

Currently running stably, temporarily closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants