Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Breaking Changes and issues closed into two separate questions #17

Closed
tusharmath opened this issue Apr 10, 2016 · 6 comments · Fixed by #44
Closed

Split Breaking Changes and issues closed into two separate questions #17

tusharmath opened this issue Apr 10, 2016 · 6 comments · Fixed by #44

Comments

@tusharmath
Copy link

The idea behind doing this is that if the user has a breaking change, you could auto prefix it with BREAKING CHANGE text. Often times there are typos while writing this text in all caps.

original issue: commitizen/cz-cli#192

@markdalgleish
Copy link
Contributor

@jimthedev is this something you want implemented? I'm happy to do this myself and send a PR—otherwise I'll have to maintain my own custom engine, which I'd rather avoid.

@travi
Copy link
Contributor

travi commented Jan 17, 2017

as another consumer, i agree that this would be a helpful change

@jimthedev
Copy link
Member

@markdalgleish @travi I would be ok with it. We're going to need to bump major versions but if you put in a PR I'd expect it to get merged. @LinusU how does this sound?

@LinusU
Copy link
Contributor

LinusU commented Jan 17, 2017

👍

@vovacodes
Copy link

@markdalgleish are you working on this? I could implement this if you don't have time

markdalgleish added a commit to markdalgleish/cz-conventional-changelog that referenced this issue Jan 29, 2017
BREAKING CHANGE: Breaking changes now automatically include the "" prefix.

closes commitizen#17
markdalgleish added a commit to markdalgleish/cz-conventional-changelog that referenced this issue Jan 29, 2017
BREAKING CHANGE: Breaking changes now automatically include the "BREAKING CHANGE: " prefix.

closes commitizen#17
markdalgleish added a commit to markdalgleish/cz-conventional-changelog that referenced this issue Jan 29, 2017
BREAKING CHANGE: Breaking changes now automatically include the "BREAKING CHANGE: " prefix.

closes commitizen#17
ebergama added a commit to ebergama/cz-conventional-changelog that referenced this issue Feb 21, 2017
…G CHANGE: " to the long descrip

Add the support of preprend the wording "BREAKING CHANGE: " to the long description by asking for a

simple question before writing the long description.

commitizen#17
jimthedev pushed a commit that referenced this issue Feb 21, 2017
BREAKING CHANGE: Breaking changes now automatically include the "BREAKING CHANGE: " prefix.

closes #17
@tusharmath
Copy link
Author

Wow Thanks a ton!

haltcase pushed a commit to haltcase/cz-conventional-changelog that referenced this issue Apr 18, 2017
…zen#44)

BREAKING CHANGE: Breaking changes now automatically include the "BREAKING CHANGE: " prefix.

closes commitizen#17
simon-watiau pushed a commit to simon-watiau/cz-conventional-changelog that referenced this issue Apr 7, 2019
…zen#44)

BREAKING CHANGE: Breaking changes now automatically include the "BREAKING CHANGE: " prefix.

closes commitizen#17
github-actions bot pushed a commit to DawChihLiou/cz-conventional-changelog-with-jiraid-detection that referenced this issue Sep 16, 2020
# 1.0.0 (2020-09-16)

### Bug Fixes

* **adapter:** Fix typo in etc. ([39182b8](39182b8))
* **build:** Add proper deps, force republish to make sure things are working ([922097b](922097b))
* **build:** Automatic releases!!! ✨ ([114f967](114f967))
* update longest to ^2 ([commitizen#88](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/88)) ([7234529](7234529))
* **commit:** Remove es6 string syntax (backticks) ([7f922f2](7f922f2))
* **commit:** remove parentheses when there is no scope present ([55f72b9](55f72b9))
* **config-loader:** captured the direct dependency on commitizen for the use of the config loader ([commitizen#90](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/90)) ([4b23bbc](4b23bbc)), closes [commitizen#89](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/89)
* **defaultValues:** Added fallback for optional default values ([commitizen#99](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/99)) ([2aae317](2aae317))
* **package.json:** install missing dependency ([4287211](4287211))
* **package.json:** update package name ([2985968](2985968))
* **prompter:** resolve issue with new inquirer api ([commitizen#18](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/18)) ([807b4e5](807b4e5))
* Correct typo in JSON ([58df4d1](58df4d1))
* **release:** attempt to fix release ([c167fd8](c167fd8))
* **release.config.js:** attempt to fix semantic release ([e362f9a](e362f9a))
* **require:** get rid of relative path to the word-wrap ([e98818a](e98818a)), closes [commitizen#4](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/4)
* **wrapping:** Fix fields to wrap instead of truncate at 100 characters ([c7b7e11](c7b7e11)), closes [commitizen/cz-cli#4](commitizen/cz-cli#4)
* remove pre-node 10 support ([commitizen#86](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/86)) ([76588ad](76588ad))
* Update conventional-commit-types to the latest version 🚀 ([commitizen#105](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/105)) ([5a371c1](5a371c1))
* Wrap updateTypes in packageRules ([0f6dfbf](0f6dfbf))

### Features

* **adapter:** Create initial commit. ([4e8da01](4e8da01))
* **adapter:** refactor to engine, default to conventional commit types ([c8452d1](c8452d1)), closes [commitizen#29](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/29)
* **adapter:** Split breaking changes into separate question ([commitizen#44](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/44)) ([2d78e1d](2d78e1d)), closes [commitizen#17](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/17)
* add default values to options ([commitizen#69](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/69)) ([65d6a9f](65d6a9f))
* implement configuration through package.json ([commitizen#75](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/75)) ([3398c02](3398c02))
* **engine:** add support for disableScopeLowerCase ([commitizen#96](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/96)) ([e7bd546](e7bd546))
* **engine:** add support for disableSubjectLowerCase ([df66875](df66875))
* **engine.js:** add jira step ([b6c6bfb](b6c6bfb))
* **prompt:** add confirmation fields + edit for clarity ([commitizen#58](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/58)) ([d40ac2c](d40ac2c)), closes [commitizen#52](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/52)
* **types:** add suport for custom types ([commitizen#104](https://github.com/DawChihLiou/cz-conventional-changelog-with-jiraid-detection/issues/104)) ([aae2548](aae2548))

### BREAKING CHANGES

* Node 10 is LTS so please upgrade to it.
* **adapter:** Breaking changes now automatically include the "BREAKING CHANGE: " prefix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants