fix(config loader): deal with config file charset #584

hxzhao527 · 2018-10-20T05:45:32Z

make sure that config file charset is utf-8, or throw detail to notify.

In the last version #525 , dependency is-utf-8 is not included explicitly. #582
I have fixed it, so open a new pr to solve #465 .

make sure that config file charset is utf-8, or throw detail to notify.

hxzhao527 and others added 6 commits May 27, 2018 10:40

fix(config loader): deal with config file charset

98a07a8

make sure that config file charset is utf-8, or throw detail to notify.

Merge branch 'master' into master

57df2ea

Update getContent.js

d3cd85c

Update package.json

898161c

fix(config loader): deal with config file charset

ffbc5b7

make sure that config file charset is utf-8, or throw detail to notify.

fix(dependency): add dependency explicit

e2171bc

hxzhao527 mentioned this pull request Oct 20, 2018

cannot find module 'is-utf8' #582

Closed

jimthedev approved these changes Feb 21, 2019

View reviewed changes

jimthedev merged commit 75b940d into commitizen:master Feb 21, 2019

Provide feedback