Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commitizen got skipped when its inside pre-commit #462

Open
adamchenwei opened this issue Dec 8, 2017 · 0 comments
Open

commitizen got skipped when its inside pre-commit #462

adamchenwei opened this issue Dec 8, 2017 · 0 comments

Comments

@adamchenwei
Copy link

Its sort similar but a bit of work around as we do not yet have solution for #448

I tried to trigger commitizen in pre-commit stage so it override the actual git commit behavior, but when commitizen ui popped up, pre-commit just ran through it instead of pausing at the commitizen step so I can utilize its UI for commit the change.
Is there way we can config pre-commit not to conclude until the first finished?

Thanks!
olgn added a commit to olgn/cz-cli that referenced this issue Mar 19, 2019
@olgn
feat(cli): implement --hook option for git hooks integration
c39489d 
using git cz --hook in a git hook will allow 'git commit' to trigger commitizen

fix commitizen#448, re commitizen#462
@olgn olgn mentioned this issue Mar 19, 2019
Merged
olgn added a commit to olgn/cz-cli that referenced this issue Mar 20, 2019
@olgn
feat(cli): implement --hook option for git hooks integration
72349d4 
using git cz --hook in a git hook will allow 'git commit' to trigger commitizen

fix commitizen#448, re commitizen#462
jimthedev pushed a commit that referenced this issue Apr 18, 2019
@olgn @jimthedev
feat(cli): Implement --hook option for git hooks integration (#615)
26533fc 
fixes #448 (re #462)

This pr allows project maintainers to enforce Commitizen generated commit messages as part of the workflow triggered by the `git commit` command. 

* implements the `--hook` flag, which directs Commitizen to edit the `.git/COMMIT_EDITMSG` file directly. 
* documents the use of the `--hook` flag in the `README`, both through traditional `git hooks` and `husky`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamchenwei