From 1181693d53910c06040989b221a8a79f64362b3f Mon Sep 17 00:00:00 2001 From: Cherif BOUCHELAGHEM Date: Mon, 22 Oct 2018 22:23:09 +0100 Subject: [PATCH] edit the test as in the review --- can-dom-events-test.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/can-dom-events-test.js b/can-dom-events-test.js index 7ee0166..0ab58b7 100644 --- a/can-dom-events-test.js +++ b/can-dom-events-test.js @@ -11,6 +11,8 @@ unit.test('domEvents.addEventListener works', function (assert) { var input = document.createElement('input'); var eventType = 'click'; var event; + var qf = document.querySelector('#qunit-fixture'); + qf.appendChild(input); var handler = function () { assert.ok(true, 'event handler should be called'); @@ -20,8 +22,6 @@ unit.test('domEvents.addEventListener works', function (assert) { if (typeof Event === "function") { event = new Event(eventType); } else { - var qf = document.querySelector('#qunit-fixture'); - qf.appendChild(input); event = document.createEvent('Event'); event.initEvent(eventType, true, false); } @@ -38,6 +38,7 @@ unit.test('domEvents.removeEventListener works', function (assert) { var eventType = 'click'; var event, event2; var qf = document.querySelector('#qunit-fixture'); + qf.appendChild(input); var handler = function () { assert.ok(true, 'event handler should be called'); }; @@ -47,7 +48,6 @@ unit.test('domEvents.removeEventListener works', function (assert) { if (typeof Event === "function") { event = new Event(eventType); } else { - qf.appendChild(input); event = document.createEvent('Event'); event.initEvent(eventType, true, true); } @@ -58,9 +58,6 @@ unit.test('domEvents.removeEventListener works', function (assert) { if (typeof Event === "function") { event2 = new Event(eventType); } else { - if (!qf.contains(input)) { - qf.appendChild(input); - } event2 = document.createEvent('Event'); event2.initEvent(eventType, true, true); }