Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaks in node 0.8 #2

Closed
ljharb opened this issue Apr 21, 2017 · 0 comments
Closed

breaks in node 0.8 #2

ljharb opened this issue Apr 21, 2017 · 0 comments

Comments

@ljharb
Copy link
Contributor

ljharb commented Apr 21, 2017

It seems process.env.hasOwnProperty fails in node 0.8.

If you use the has package, then it will work everywhere. PR incoming.
ljharb added a commit to ljharb/safe-publish-latest that referenced this issue Apr 21, 2017
@ljharb
[Tests] allow 0.8 to fail, pending burl/mock-env#2
52bf797
@ljharb ljharb mentioned this issue Apr 21, 2017
Merged
ljharb added a commit to ljharb/safe-publish-latest that referenced this issue Apr 21, 2017
@ljharb
[Tests] allow 0.8 to fail, pending burl/mock-env#2
376c98d
@burl burl closed this as completed in #3 May 23, 2017
ljharb added a commit to ljharb/safe-publish-latest that referenced this issue Jun 16, 2017
@ljharb
[Tests] require 0.8 to be passing again
040194f 
Revert "[Tests] allow 0.8 to fail, pending burl/mock-env#2"

This reverts commit 376c98d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ljharb