default withRelated by Model

[ghost]

With bookshelf 0.8.x I append default relation in fetch with this code:

initialize: function() {
  this.on('fetching fetching:collection', function(model, columns, options) {
    if (!options.withRelated) {
      options.withRelated = [];
    }
    options.withRelated.push("country");
}

but in 'bookshelf' 0.10.2 not work, some alternative for default relation?

[jamesdixon]

@vxcamiloxv did you ever get this to work properly?

This also doesn't work for me using Bookshelf 0.12.1.

[ricardograca]

It looks like the code that handles this event has been like that since about version 0.8.2. Also, from looking at the code I see no reason why this wouldn't work, but I haven't looked too deeply or investigated much.

Can any of you provide a reproducible test case for this issue?

[ghost]

In 0.8.x works fine but in 0.12.1 I was getting Maximum call stack size exceeded

[ghost]

To reproduce this error you need some table like city with a foreign key to country

• City table

------------------------------
id | name    | country_id
------------------------------
1  | Bogotá  | 2
------------------------------

• Country table

------------------------------
id | name       | locale 
------------------------------
1  | Mexico     |  es_MX
------------------------------
2  | Colombia   |  es_CO
------------------------------

and the above code always when city is fetched (new City({'id': 1})) adds as relation country for getting something like:

{
  city: {
   id: 1,
   name: "Bogotá",
   country: {
     id: 2,
     name: "Colombia",
     locale: "es_CO"
  }
 } 
}

[ricardograca]

This seems to be fixed with the latest version. Either that or there is some information missing from this issue.

Check PR #1853 for a test case that is similar to the mentioned steps to reproduce.