[Fix] no-common-js: Also throw an error when assigning

import-js · May 5, 2019 · 1edbbd0 · 1edbbd0
1 parent f63dd26
commit 1edbbd0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/rules/no-commonjs.js b/src/rules/no-commonjs.js
@@ -91,6 +91,7 @@ module.exports = {
         if (
           call.parent.type !== 'ExpressionStatement'
           && call.parent.type !== 'VariableDeclarator'
+          && call.parent.type !== 'AssignmentExpression'
         ) return
 
         if (call.callee.type !== 'Identifier') return

diff --git a/tests/src/rules/no-commonjs.js b/tests/src/rules/no-commonjs.js
@@ -60,6 +60,7 @@ ruleTester.run('no-commonjs', require('rules/no-commonjs'), {
 
     // imports
     { code: 'var x = require("x")', errors: [ { message: IMPORT_MESSAGE }] },
+    { code: 'x = require("x")', errors: [ { message: IMPORT_MESSAGE }] },
     { code: 'require("x")', errors: [ { message: IMPORT_MESSAGE }] },
 
     // exports