Use rules.payload when extracting data for event stream #4607
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inf3rnus
changed the title
This was referenced Mar 8, 2024
Closed
trivikr
reviewed
May 23, 2024
| @@ -75,7 +76,7 @@ function extractData(resp) { | |||
| var body = resp.httpResponse.body; | |||
| if (payloadMember.isEventStream) { | |||
| parser = new JsonParser(); | |||
| resp.data[payload] = util.createEventStream( | |||
| resp.data[rules.payload] = util.createEventStream( | |||
There was a problem hiding this comment.
Looks like this was a miss in #2085, likely while doing copy-paste from rest-xml.js
trivikr
changed the title
trivikr
approved these changes
May 23, 2024
kuhe
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4580, problem is that there were undefined variables in
lib/protocol/rest_json.jsFile could use more cleanup as well, as there are also unused variables from whoever touched it last.
Without this change, you cannot use the client to get a streamed sagemaker request.
Checklist
npm run testpasses (tests seem flaky, less are failing after this change, and failures change with each run, before and after the change. Your guys' judgement call)npm run integrationif integration test is changed (tests are flaky and also just fail, always fail on my machine before and after change, didn't change them)