Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecate CoreModule #6588

Merged
merged 1 commit into from Aug 29, 2017
Merged

fix: deprecate CoreModule #6588

merged 1 commit into from Aug 29, 2017

Conversation

jelbourn
Copy link
Member

Since most of this functionality has been moved into @angular/cdk, it
no longer makes sense to blob it all together in one NgModule inside
@angular/material.

@jelbourn
fix: deprecate CoreMore
e056066 
Since most of this functionality has been moved into `@angular/cdk`, it
no longer makes sense to blob it all together in one NgModule inside
`@angular/material`.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 22, 2017
@rafaelss95
Copy link
Contributor

rafaelss95 commented Aug 22, 2017 •
edited

I think there's a typo: CoreMore -> CoreModule

@jelbourn jelbourn changed the title fix: deprecate CoreMore fix: deprecate CoreModule Aug 22, 2017
tinayuangao
tinayuangao approved these changes Aug 29, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 29, 2017
@jelbourn jelbourn merged commit 377a3bb into angular:master Aug 29, 2017
@jelbourn jelbourn deleted the core-module-deprecated branch April 2, 2018 22:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tinayuangao tinayuangao tinayuangao approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jelbourn @rafaelss95 @tinayuangao @googlebot