Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snack-bar): align theming with spec #6506

Merged
merged 1 commit into from Aug 22, 2017

Conversation

crisbeto
Copy link
Member

Aligns the snack bar theming with the spec by:

  • Sets the accent color to the snack bar button.
  • Removes the elevation from the snack bar.
  • Adds an inverted black&white snack bar for dark themes. Based on MDC.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 16, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 16, 2017
@kara kara added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Aug 21, 2017
@kara kara assigned crisbeto and unassigned jelbourn Aug 21, 2017
@kara
Copy link
Contributor

kara commented Aug 21, 2017

@crisbeto Rebase?

Aligns the snack bar theming with the spec by:
* Sets the accent color to the snack bar button.
* Removes the elevation from the snack bar.
* Adds an inverted black&white snack bar for dark themes. Based on MDC.
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Aug 22, 2017
@kara kara merged commit 363562f into angular:master Aug 22, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants