Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabs): allow for tabs to be selected using the space key #6426

Merged
merged 1 commit into from Aug 15, 2017
Merged

fix(tabs): allow for tabs to be selected using the space key #6426

merged 1 commit into from Aug 15, 2017

Conversation

crisbeto
Copy link
Member

  • Allows for the user to select a tab using the space key, in addition to enter. This seems to be consistent with the M1 implementation of tabs.
  • Prevents the default action for space and enter in order to prevent the page from scrolling by accident.

Fixes #6406.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 11, 2017
jelbourn
jelbourn approved these changes Aug 14, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

Just needs rebase

@crisbeto
fix(tabs): allow for tabs to be selected using the space key
1d399d2 
* Allows for the user to select a tab using the space key, in addition to enter. This seems to be consistent with the M1 implementation of tabs.
* Prevents the default action for space and enter in order to prevent the page from scrolling by accident.

Fixes angular#6406.
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Aug 14, 2017
@andrewseguin andrewseguin merged commit b5f4caf into angular:master Aug 15, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] Select md-tab-group by highlighting and pressing space key
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin