Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] Select md-tab-group by highlighting and pressing space key #6406

Closed
msc117 opened this issue Aug 10, 2017 · 1 comment · Fixed by #6426
Closed

[feature request] Select md-tab-group by highlighting and pressing space key #6406

msc117 opened this issue Aug 10, 2017 · 1 comment · Fixed by #6426

Comments

@msc117
Copy link

msc117 commented Aug 10, 2017

Bug, feature request, or proposal:

feature request

What is the expected behavior?

Highlighted tab is selectable by both enter and space key

What is the current behavior?

Only enter key

What are the steps to reproduce?

Create tab group, focus a tab, press space
http://plnkr.co/edit/kLMZ6Oe67mmTXx6TAY34?p=info

What is the use-case or motivation for changing an existing behavior?

This behavior is used throughout other components and fairly standard to select highlighted option through space or enter

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

2.0.0-beta.8

Is there anything else we should know?

I can self assign and do this myself if not being worked on already
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 11, 2017
@crisbeto
fix(tabs): allow for tabs to be selected using the space key
62e92df 
* Allows for the user to select a tab using the space key, in addition to enter. This seems to be consistent with the M1 implementation of tabs.
* Prevents the default action for space and enter in order to prevent the page from scrolling by accident.

Fixes angular#6406.
@crisbeto crisbeto mentioned this issue Aug 11, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 14, 2017
@crisbeto
fix(tabs): allow for tabs to be selected using the space key
1d399d2 
* Allows for the user to select a tab using the space key, in addition to enter. This seems to be consistent with the M1 implementation of tabs.
* Prevents the default action for space and enter in order to prevent the page from scrolling by accident.

Fixes angular#6406.
andrewseguin pushed a commit that referenced this issue Aug 15, 2017
@crisbeto @andrewseguin
fix(tabs): allow for tabs to be selected using the space key (#6426)
b5f4caf 
* Allows for the user to select a tab using the space key, in addition to enter. This seems to be consistent with the M1 implementation of tabs.
* Prevents the default action for space and enter in order to prevent the page from scrolling by accident.

Fixes #6406.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tabs): allow for tabs to be selected using the space key crisbeto/material2
2 participants
@crisbeto @msc117