Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theming): Light green 700 contrast should be white #6346

Merged
merged 1 commit into from Aug 9, 2017

Conversation

cladera
Copy link
Contributor

@cladera cladera commented Aug 8, 2017

According to Material Design Guidelines Light Green 700 contrast color
should be white.

According to [Material Design Guidelines](https://material.io/guidelines/style/color.html#color-color-palette) Light Green 700 contrast color
should be white.

BREAKING CHANGE:

`$mat-light-green 700 contrast color now is white.
@cladera cladera requested a review from jelbourn as a code owner August 8, 2017 13:53
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 8, 2017
@cladera
Copy link
Contributor Author

cladera commented Aug 8, 2017

I added a Breaking Change message since it may have an unexpected behaviour for those using this color since it may change entirely the look of their applications.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 8, 2017
@mmalerba mmalerba merged commit b4e2488 into angular:master Aug 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants