Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): close child menus when parent is closed programmatically #6329

Merged
merged 1 commit into from Aug 15, 2017
Merged

fix(menu): close child menus when parent is closed programmatically #6329

merged 1 commit into from Aug 15, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 7, 2017

Fixes the child menus not closing themselves when a parent menu is closed via closeMenu.

@crisbeto
fix(menu): close child menus when parent is closed programmatically
7266a13 
Fixes the child menus not closing themselves when a parent menu is closed via `closeMenu`.
@crisbeto crisbeto requested a review from kara as a code owner August 7, 2017 20:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 7, 2017
kara
kara approved these changes Aug 9, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 9, 2017
@kara kara removed their assignment Aug 9, 2017
@andrewseguin andrewseguin merged commit 66b1ff5 into angular:master Aug 15, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @kara @googlebot @andrewseguin