Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): export unexported components for potential extension #6314

Merged
merged 1 commit into from Aug 8, 2017

Conversation

e-cloud
Copy link
Contributor

@e-cloud e-cloud commented Aug 7, 2017

Although the team has export those files, but users can't redeclare them in another NgModule for angular constraints. It's impossible for someone to extend the functionality or create a custom date(time)picker view without this patch.

Although the team has export those files, but users can't redeclare them in another NgModule for angular constraints. It's impossible for someone to extend the functionality or create a custom date(time)picker view without this patch.
@e-cloud e-cloud requested a review from mmalerba as a code owner August 7, 2017 03:50
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 7, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 7, 2017
@mmalerba mmalerba merged commit 7bc648b into angular:master Aug 8, 2017
@e-cloud e-cloud deleted the feature/datepicker-extensibility branch August 9, 2017 02:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants