Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay): error when removing empty string theme #6306

Merged
merged 1 commit into from Aug 7, 2017
Merged

fix(overlay): error when removing empty string theme #6306

merged 1 commit into from Aug 7, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 6, 2017

Something I ran into while doing #6305. If the previous overlay theme is a blank string, switching to another theme throws an error.

@crisbeto
fix(overlay): error when removing empty string theme
a6d1d52 
Something I ran into while doing angular#6305. If the previous overlay theme is a blank string, switching to another theme throws an error.
@crisbeto crisbeto requested a review from jelbourn as a code owner August 6, 2017 15:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 6, 2017
jelbourn
jelbourn approved these changes Aug 7, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I could have sworn I saw another PR for this. I found #5194, but that's definitely not what I was thinking of.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 7, 2017
@jelbourn jelbourn mentioned this pull request Aug 7, 2017
Closed
@mmalerba mmalerba merged commit faa7601 into angular:master Aug 7, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @jelbourn @googlebot @mmalerba