fix(select,autocomplete): darken selected option #6302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Aug 7, 2017
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| // In multiple mode there is a checkbox to show that the option is selected. | |||
| &.mat-selected:not(.mat-option-multiple) { | |||
| background: mat-color($background, hover); | |||
| background: rgba(mat-color($background, hover), 0.12); | |||
There was a problem hiding this comment.
fyi mat-color should take opacity as a third argument, but it's the same either way
There was a problem hiding this comment.
I tried that initially and I kept getting some weird SASS error.
There was a problem hiding this comment.
Weird, it works now. It must've been something else.
jelbourn
added
pr: lgtm
action: merge
Darkens the selected option background in order to distinguish it from the ones that are focused or hovered. Fixes angular#6229.
crisbeto
force-pushed
the
6229/darken-option-background
branch
from
413bdc0
to
bef4e76
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Darkens the selected option background in order to distinguish it from the ones that are focused or hovered.
Fixes #6229.