feat(dialog): open dialog API improvements #6289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
* Makes the `openDialog` public. * Adds a unique id to each `MdDialogRef`, as well as the option to override the id and to look dialogs by id. * The `afterAllClosed` stream now emits on subscribe if there are no open dialogs. Fixes angular#6272.
crisbeto
force-pushed
the
6272/dialog-state-improvements
branch
from
d7530d1
to
f911655
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openDialogpublic.MdDialogRef, as well as the option to override the id and to look dialogs up by id.afterAllClosedstream now emits on subscribe if there are no open dialogs.Fixes #6272.